refactor(dc_measurements,dc_core): rename custom_params to custom_keys - #318
Merged
Merged
Conversation
What custom_str_params/custom_params add are custom keys in the Record JSON, not parameters of the node. Rename the node parameters (custom_str_params_list -> custom_key_str_list, custom_str_params -> custom_keys_str) and every C++ variable/member/method mirroring them (custom_params_ -> custom_keys_, setCustomParameters -> setCustomKeys, addCustomParameters -> addCustomKeys, etc.), and update demo configs, docs, and the strictdoc requirements to match. Note the breaking config rename in migration.md. Closes #186 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DgSaCimN2ce7nborgttsPB Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DgSaCimN2ce7nborgttsPB Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jazzy #318 +/- ##
==========================================
+ Coverage 40.80% 40.81% +0.01%
==========================================
Files 82 82
Lines 4920 4919 -1
==========================================
Hits 2007 2007
+ Misses 2913 2912 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measurement_server'scustom_str_params_list/custom_str_paramsnode parameters tocustom_key_str_list/custom_keys_str— what these add to a Record is custom keys in the serialized JSON, not parameters of the node.dc_core/dc_measurements(custom_params_->custom_keys_,setCustomParameters/addCustomParameters->setCustomKeys/addCustomKeys, etc.), the 7 demo configs underdc_demos/params/, the docs, and themeasurement_server.sdocrequirements.doc/src/dc/migration.md(before/after snippet + checklist item) for anyone upgrading an existingjazzycheckout.Test plan
custom_paramoccurrences remain outside the gitignoreddoc/book/build output.pre-commit run --all-files— hooks touching this diff's files (check-xml,pyupgrade,clang-format) ran clean. Other failures in the same run (build-dochitting a stale local Podman boot-ID cache,poetry-requirementsmissingpoetry,flake8findings in files this change never touches) are pre-existing local-environment issues, not caused by this diff.doc/src/dc/requirements/html//doc/book/artifacts not regenerated locally (strictdocunavailable, Podman docs image blocked by the boot-ID cache issue above) — the.sdocedit is a pure text substitution inside existingSTATEMENTfields, not a structural change, so CI's docs build (starting from a clean runner) should pick it up cleanly.Closes #186
🤖 Generated with Claude Code
https://claude.ai/code/session_01DgSaCimN2ce7nborgttsPB